Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.x] Break out quotes method #43397

Merged
merged 1 commit into from
Jul 25, 2022
Merged

[9.x] Break out quotes method #43397

merged 1 commit into from
Jul 25, 2022

Conversation

dwightwatson
Copy link
Contributor

This is a little odd so I'm happy if this considered not worth fixing, but I've been using Illuminate\Foundation\Inspiring::quote() in my production app - showing a nice quote to our internal teams when they've completed the list of pending tasks.

Despite the lovely new changes to the console, it appears the quote is formatted for the console regardless of the context:

<options=bold>“ Happiness is not something readymade. It comes from your own actions. ”</> <fg=gray>— Dalai Lama</>

This breaks out a quotes method so the quotes can be accessed separately. It'll mean I can just do Inspiring::quotes::random() in my own code and not impact the existing use-cases of quote().

@taylorotwell taylorotwell merged commit b13a1bc into laravel:9.x Jul 25, 2022
Ken-vdE pushed a commit to Ken-vdE/framework that referenced this pull request Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants