New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix merging casts with dates for PHP 8.0 #43308

Closed

sebdesign wants to merge 1 commit into laravel:9.x from sebdesign:fix-merge-casts-dates

Contributor

sebdesign commented Jul 20, 2022

When running php artisan model:show in PHP 8.0, the following error is thrown:

Cannot unpack Traversable with string keys

  at vendor/laravel/framework/src/Illuminate/Foundation/Console/ShowModelCommand.php:349
    345▕      */
    346▕     protected function getCastsWithDates($model)
    347▕     {
    348▕         return collect([
  ➜ 349▕             ...collect($model->getDates())->flip()->map(fn () => 'datetime'),
    350▕             ...$model->getCasts(),
    351▕         ]);
    352▕     }
    353▕

That is because array unpacking with string keys was implemented in PHP 8.1.
A simple merge will fix this BC break.


          Fix merging casts with dates for PHP 8.0

2fbcf1b

Member

nunomaduro commented Jul 20, 2022

There is already a pull request that addresses this issue: #43301.

nunomaduro closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet