New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.x] Consistent `Stringable::swap()` & `Str::swap()` implementations #40855

Merged

taylorotwell merged 1 commit into laravel:8.x from derekmd:stringable-swap-calls-strtr

Feb 7, 2022

Contributor

derekmd commented Feb 7, 2022

Commit 609351c missed that Stringable::swap() doesn't invoke Str::swap().

Make both methods use strtr().


          Make Stringable::swap() match Str::swap() implementation

28b5829

Both call function strtr().

derekmd mentioned this pull request

[8.x] Make Str::swap() first argument the string value #40853

Closed

taylorotwell merged commit 277d590 into laravel:8.x

derekmd deleted the stringable-swap-calls-strtr branch

February 7, 2022 21:27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet