[9.x] Flysystem v3 support #40411
Merged
[9.x] Flysystem v3 support #40411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0cee559 to
e961b33
Compare
driesvints
commented
Jan 14, 2022
| * | ||
| * @param string $path | ||
| * @return bool | ||
| */ | ||
| public function exists($path) | ||
| { | ||
| return $this->driver->fileExists($path); | ||
| return $this->driver->has($path); |
There was a problem hiding this comment.
This was how it's currently on 8.x:
driesvints
commented
Jan 14, 2022
| @@ -378,7 +422,7 @@ public function setVisibility($path, $visibility) | |||
| */ | |||
| public function prepend($path, $data, $separator = PHP_EOL) | |||
| { | |||
| if ($this->exists($path)) { | |||
| if ($this->fileExists($path)) { | |||
There was a problem hiding this comment.
I adjusted these because these methods are specifically for files.
e961b33 to
0beb934
Compare
71 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces Flysystem v3 support for Laravel 9. I've implemented the new
hasmethod that checks for both a file and directory. I've updated the subsequent methods docblock descriptions and assertion messages to make that more clear. It's how the behaviour is now in Laravel 8.I've also added complementary
fileExists,directoryExistsand theirmissingequivalents. I didn't addassertExistsequivalents because that felt a little overkill.