[8.x] SimpleMessage: Add method to add multiple lines as once #40147

andershagbard · 2021-12-23T13:34:20Z

Not sure if we can change the phpdoc to:

@param  mixed[]  $lines

mateusjunges

Mixed can be string, which will resut in a php warning:

PHP Warning:  Invalid argument supplied for foreach()

src/Illuminate/Notifications/Messages/SimpleMessage.php

Co-authored-by: Mateus Junges <mateus@junges.dev>

Add lines method

212dd86

andershagbard changed the title ~~MailMessage: Add method to add multiple lines as once~~ SimpleMessage: Add method to add multiple lines as once Dec 23, 2021

andershagbard added 2 commits December 23, 2021 14:34

Fix style

c8cf177

Fix doc

d39d185

GrahamCampbell changed the title ~~SimpleMessage: Add method to add multiple lines as once~~ [8.x] SimpleMessage: Add method to add multiple lines as once Dec 23, 2021

mateusjunges reviewed Dec 23, 2021

View reviewed changes

src/Illuminate/Notifications/Messages/SimpleMessage.php Outdated Show resolved Hide resolved

andershagbard and others added 3 commits December 24, 2021 11:14

Update src/Illuminate/Notifications/Messages/SimpleMessage.php

f948b59

Co-authored-by: Mateus Junges <mateus@junges.dev>

Update SimpleMessage.php

e7d478a

Update SimpleMessage.php

2d7c6ec

taylorotwell merged commit f26e36b into laravel:8.x Dec 25, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[8.x] SimpleMessage: Add method to add multiple lines as once #40147

[8.x] SimpleMessage: Add method to add multiple lines as once #40147

andershagbard commented Dec 23, 2021 •

edited

Loading

mateusjunges left a comment

[8.x] SimpleMessage: Add method to add multiple lines as once #40147

[8.x] SimpleMessage: Add method to add multiple lines as once #40147

Conversation

andershagbard commented Dec 23, 2021 • edited Loading

mateusjunges left a comment

Choose a reason for hiding this comment

andershagbard commented Dec 23, 2021 •

edited

Loading