[9.x] Remove parameter from DecoratesQueryBuilder::delete() #39900
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#37956 added the
DecoratesQueryBuilder
trait to improve type hinting.delete()
is a special case as its method signature inEloquent\Builder
is different fromQuery\Builder
. Only the base query builder has an$id
parameter, the Eloquent one doesn't:framework/src/Illuminate/Database/Eloquent/Builder.php
Line 1031 in 05bba7c
framework/src/Illuminate/Database/Query/Builder.php
Line 2700 in 05bba7c
The trait is used in relationship classes and so the IDE suggests that
$user->posts()->delete(1)
works, but the parameter is actually ignored becauseEloquent\Builder::delete()
doesn't pass it on toQuery\Builder::delete().