-
Notifications
You must be signed in to change notification settings - Fork 11.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[8.x] Model Broadcasting - Adding broadcastWith() and broadcastAs() support #38137
Merged
taylorotwell
merged 16 commits into
laravel:8.x
from
clemblanco:custom-payload-and-name-for-model-event-broadcasting
Jul 27, 2021
Merged
[8.x] Model Broadcasting - Adding broadcastWith() and broadcastAs() support #38137
taylorotwell
merged 16 commits into
laravel:8.x
from
clemblanco:custom-payload-and-name-for-model-event-broadcasting
Jul 27, 2021
+217
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driesvints
reviewed
Jul 26, 2021
Converted this to a draft until you've managed to fix the tests. Feel free to mark as ready when you're done. |
@driesvints It's now ready even thought it seems like PHP 8.1 tests are marked as passed while it looks like GitHub Actions say otherwise. Are you aware of this? |
@clemblanco yes, feel free to ignore those. |
@driesvints In that case it's ready for you to have a look. Let me know what you think.✌️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two optional model methods
broadcastAs()
andbroadcastWith()
when using Model Broadcasting.When using broadcasting basic Events, we can specify which broadcast data and broadcast name should be used using both
broadcastAs()
andbroadcastWith()
.However, when using Model Broadcasting, we don't have that flexibility as it stands.
Similar to what the framework already does for
broadcastOn()
, we could use:Just like
broadcastOn()
:match()
statement will default to Laravel's default behaviourmatch()
expression (orswitch()
for php 7) and always return the same string or arrayBonus: missing unit tests
broadcastOn()
to specify a channel for given events was not covered