[8.x] Add Conditionable Trait to Relation #37640
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Thank you for all the amazing work 🔥
Overview
This PR adds the new
Conditionable
trait to the baseRelation
class.Currently, the following would not work for a relationship query...
...because the
Relation
class does not have a nativewhen/unless
. So, it forwards it to theBuilder
but then this does not have access to theRelation's
methods - in this caseorderByPivot
.Compatibility
The only thought is that this could be a breaking change in the sense that some relations override some
Relation
methods - eg.get
inBelongsToMany
. So if any apps do something along the lines of......the
get
method would now be elevated from theBuilder
up to theRelation
?Tests
Testing wise, I appreciate there is only one test. I felt it illustrated the feature nicely using an existing set up. But very happy to add more if desired.