[8.x] Allow lazy collection to be instantiated from a generator #36738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JosephSilber
reviewed
Apr 1, 2021
Comment on lines
+72
to
+95
| public function testCanCreateCollectionFromGenerator() | ||
| { | ||
| $iterable = function () { | ||
| yield 1; | ||
| yield 2; | ||
| yield 3; | ||
| }; | ||
| $data = LazyCollection::make($iterable()); | ||
|
|
||
| $this->assertSame([1, 2, 3], $data->all()); | ||
|
|
||
| $iterable = function () { | ||
| yield 'a' => 1; | ||
| yield 'b' => 2; | ||
| yield 'c' => 3; | ||
| }; | ||
| $data = LazyCollection::make($iterable()); | ||
|
|
||
| $this->assertSame([ | ||
| 'a' => 1, | ||
| 'b' => 2, | ||
| 'c' => 3, | ||
| ], $data->all()); | ||
| } |
There was a problem hiding this comment.
These tests pass either way (even without the changes in this PR).
These tests do not check for laziness.
|
For anyone reading this in the future, be sure to read my comment here: #36837 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes you may be in a position where you have a generator, which you would like to pass into a lazy collection. Right now you would have to do something like the following:
With this change, you would be able to call
LazyCollection::make($source);directly.