Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] Show warning when view exists when using artisan make:component #34376

Merged
merged 3 commits into from
Sep 16, 2020
Merged

[8.x] Show warning when view exists when using artisan make:component #34376

merged 3 commits into from
Sep 16, 2020

Conversation

rojtjo
Copy link
Contributor

@rojtjo rojtjo commented Sep 16, 2020

When building views I often start building them with anonymous components, once I have the need for more logic I create the actual component class. I noticed however when using the make:component command it overwrites the already existing component view without any warning.

This change ensures a warning is shown to the user when the view already exists and prevents it from being overwritten. When the --force flag is used the exists check is ignored and the view is overwritten like before.

@taylorotwell taylorotwell merged commit 468b1be into laravel:8.x Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants