[6.x] Fix Faker Unique caching issue #32703
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #32700
I tested this change in my own codebase and it worked. The idea is somewhat simple: Assuming Faker is a singleton, the Container factory is executed only once per test. That means within a test, Faker will do it's job of ensuring uniqueness whenever asked.
As soon as the test finishes and the container is flushed, Laravel will start a container from scratch, which will run the container factory once again and it will clear the unique cache from faker by calling
$faker->unique(true)
(as suggested #32700 (comment)).The reason for this description is to pay extra attention in
$app->singleton()
. This is not something easy to catch on a unit test, after all we're testing if unique works across multiple tests. If somebody ever makes Faker a non-singleton, that would cause the factory to be executed on every instantiation of the class and would again break the unique().