[6.x] Add assertion for empty job chain #31332
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the
assertPushedWithEmptyChain
assertion.I found myself to implement conditional job chaining:
It's possible to pass an empty chain, but right now there is no way to test it.
The
assertPushedWithChain
does not accept an empty array for the expected chain and theassertPushed
can't tell whether the chain is empty or not.I'm not sure, this is the cleanest approach, I'm up to any idea.