Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.x] Add assertNoContent to TestResponse #30125

Merged
merged 2 commits into from
Sep 30, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions src/Illuminate/Foundation/Testing/TestResponse.php
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,21 @@ public function assertOk()
return $this;
}

/**
* Assert that the response has the given status code and no content.
*
* @param int $status
* @return $this
*/
public function assertNoContent($status = 204)
{
$this->assertStatus($status);

PHPUnit::assertEmpty($this->getContent(), 'Response content is not empty.');

return $this;
}

/**
* Assert that the response has a not found status code.
*
Expand Down
48 changes: 48 additions & 0 deletions tests/Foundation/FoundationTestResponseTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -194,6 +194,54 @@ public function testAssertUnauthorized()
$response->assertUnauthorized();
}

public function testAssertNoContentAsserts204StatusCodeByDefault()
{
$statusCode = 500;

$this->expectException(AssertionFailedError::class);

$this->expectExceptionMessage("Expected status code 204 but received {$statusCode}");

$baseResponse = tap(new Response, function ($response) use ($statusCode) {
$response->setStatusCode($statusCode);
});

$response = TestResponse::fromBaseResponse($baseResponse);
$response->assertNoContent();
}

public function testAssertNoContentAssertsExpectedStatusCode()
{
$statusCode = 500;
$expectedStatusCode = 418;

$this->expectException(AssertionFailedError::class);

$this->expectExceptionMessage("Expected status code {$expectedStatusCode} but received {$statusCode}");

$baseResponse = tap(new Response, function ($response) use ($statusCode) {
$response->setStatusCode($statusCode);
});

$response = TestResponse::fromBaseResponse($baseResponse);
$response->assertNoContent($expectedStatusCode);
}

public function testAssertNoContentAssertsEmptyContent()
{
$this->expectException(AssertionFailedError::class);

$this->expectExceptionMessage('Response content is not empty');

$baseResponse = tap(new Response, function ($response) {
$response->setStatusCode(204);
$response->setContent('non-empty-response-content');
});

$response = TestResponse::fromBaseResponse($baseResponse);
$response->assertNoContent();
}

public function testAssertStatus()
{
$statusCode = 500;
Expand Down