[5.7] Revert breaking filesystem changes #26231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfn
approved these changes
Oct 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to revert PR #26010
Although the PR was merged 16 days ago, it was only "tagged" 18 hours ago. We already have 3x reported issues of people experiencing file system permissions issues, which all of them mention that reverting to
5.7.9solves their problems: #26230, #26229 and at the bottom of the PR #26010Arguably the problem is not the PR itself, but incorrect file permissions on existing projects.
The issue is as more people start running
composer updatewe are likely to see an increase in reported tickets. And these problems might not appear until the application is pushed to production, which is even worse.So I suggest the PR perhaps should be targetted to
5.8and listed as part of the upgrade checklist.Of course, reverting the PR re-introduces the original edge case bug that it solved - but that seemed to be less of an issue. 🤷♂️
p.s. I couldnt create an automatic PR to "revert" the changes, as there have been formatting changes since. So if people could cross check this PR with the original to make sure it's a correct revert - that would be helpful.