[5.6] Fix *scan methods for phpredis #24313
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the adapter methods to properly utilize PhpRedis commands for scan, sscan, hscan, and zscan. fixes #24222 .... take 3.
I think there was some confusion caused by myself perhaps, I fell into an old work habit where if a PR was rejected, that meant a new branch because enough was wrong that it was beyond fixing. Clearly that is not what was expected, so I noticed the merge that caused the failed tests was drawing from the original branch. I won't be making that mistake again and will just continue on the same branch for a feature, but just to be clear the branch name changed and I added a v2 on the end. I apologize for that....still relatively new to contributing.
To be clear the most current branch is fix-scan-methods-for-phpredis-v2. I do still have the old branch locally, so if it makes it easier I can just move the changes from this branch to the original and retarget the PR.