Http::get('URL')->throw() will now throw "Argument 0 not passed to function"

[yateric]

• Laravel Version: 8.7.1
• PHP Version: 7.4.10
• Database Driver & Version: Not related

Description:

// framework/src/Illuminate/Http/Client/Response.php

public function throw()
{
    $callback = func_get_arg(0);

    if ($this->serverError() || $this->clientError()) {
        if ($callback && is_callable($callback)) {
            $callback($this, $exception = new RequestException($this));
        }

        throw $exception;
    }

    return $this;
}

It will throw Argument 0 not passed to function if no argument is passed.

Steps To Reproduce:

Http::get('https://www.laravel.com')->throw()->body();

This code will throw the Argument 0 not passed to function in Laravel 8.7.1

[MiniCodeMonkey]

Thanks for reporting this. I also posted some details about it here: d034e2c#r42849328

[MiniCodeMonkey]

Any reason not to do public function throw($callback = null) instead of using func_get_arg(0)?

[rodrigopedra]

@MiniCodeMonkey , changing the method signature would be a breaking change for users that are extending this class, and as breaking change it would only be released on Laravel 9.

So the approach allows us to add this new feature without introducing a BC.

[MiniCodeMonkey]

Ah. That totally makes sense. Thanks for clarifying!

On September 30, 2020, GitHub ***@***.***> wrote: @MiniCodeMonkey <https://github.com/MiniCodeMonkey> , changing the method signature would be a breaking change for users that are extending this class, and as breaking change it would only be released on Laravel 9. So the approach allows us to add this new feature without introducing a BC.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#34591 (comment)- 701435463>, or unsubscribe <https://github.com/notifications/unsubscribe- auth/AABV254UJIE5TOTYXDNCL3TSIM7QNANCNFSM4R6RCOSQ>.

[andrey-helldar]

@taylorotwell, #34597 fix accepted. Tell me, when is the patch release planned?

[driesvints]

@andrey-helldar releases are done on Tuesdays.

[andrey-helldar]