[10.x] Fix whenAggregated when default is not specified (#49521)

* Fix: whenAggregated should return MissingValue when default is not specified * Test: whenAggregated should return MissingValue when default is not specified
laravel · Jan 1, 2024 · f8c6360 · f8c6360
1 parent a5f661f
commit f8c6360
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/Illuminate/Http/Resources/ConditionallyLoadsAttributes.php b/src/Illuminate/Http/Resources/ConditionallyLoadsAttributes.php
@@ -320,6 +320,10 @@ public function whenCounted($relationship, $value = null, $default = null)
      */
     public function whenAggregated($relationship, $column, $aggregate, $value = null, $default = null)
     {
+        if (func_num_args() < 5) {
+            $default = new MissingValue;
+        }
+
         $attribute = (string) Str::of($relationship)->snake()->append('_')->append($aggregate)->append('_')->finish($column);
 
         if (! isset($this->resource->getAttributes()[$attribute])) {

diff --git a/tests/Integration/Http/ResourceTest.php b/tests/Integration/Http/ResourceTest.php
@@ -502,8 +502,6 @@ public function testResourcesMayHaveOptionalRelationshipAggregates()
             'data' => [
                 'id' => 5,
                 'title' => 'Test Title',
-                'average_rating' => null,
-                'minimum_rating' => null,
                 'maximum_rating' => 'Default Value',
             ],
         ]);