Skip to content

Commit

Permalink
Convert interfaces (introduced in after 11.0.0) from docblock to method
Browse files Browse the repository at this point in the history
For backward compatibility, we typically add new method to Interface
using docblock on minor/patch releases. This should be a good time to
declare them as actual method.

Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
  • Loading branch information
crynobone committed Jan 25, 2025
1 parent f107d93 commit cd9193b
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 6 deletions.
14 changes: 11 additions & 3 deletions src/Illuminate/Contracts/Routing/UrlGenerator.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,6 @@

namespace Illuminate\Contracts\Routing;

/**
* @method string query(string $path, array $query = [], mixed $extra = [], bool|null $secure = null)
*/
interface UrlGenerator
{
/**
Expand Down Expand Up @@ -86,6 +83,17 @@ public function signedRoute($name, $parameters = [], $expiration = null, $absolu
*/
public function temporarySignedRoute($name, $expiration, $parameters = [], $absolute = true);

/**
* Generate an absolute URL with the given query parameters.
*
* @param string $path
* @param array $query
* @param mixed $extra
* @param bool|null $secure
* @return string
*/
public function query($path, $query = [], $extra = [], $secure = null);

/**
* Get the URL to a controller action.
*
Expand Down
11 changes: 8 additions & 3 deletions src/Illuminate/Queue/Failed/FailedJobProviderInterface.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,6 @@

namespace Illuminate\Queue\Failed;

/**
* @method array ids(string $queue = null)
*/
interface FailedJobProviderInterface
{
/**
Expand All @@ -18,6 +15,14 @@ interface FailedJobProviderInterface
*/
public function log($connection, $queue, $payload, $exception);

/**
* Get the IDs of all of the failed jobs.
*
* @param string|null $queue
* @return array
*/
public function ids($queue = null);

/**
* Get a list of all of the failed jobs.
*
Expand Down

0 comments on commit cd9193b

Please sign in to comment.