fix bug for always throwing exception when we pass a callable to thro…

…wUnlessStatus method [test included] (#48844) * fix bug for always throwing exception when we pass a callable * added test for throwUnlessStatus method with callable input returning true
laravel · Oct 30, 2023 · c55667a · c55667a
1 parent 0646f33
commit c55667a
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/src/Illuminate/Http/Client/Response.php b/src/Illuminate/Http/Client/Response.php
@@ -338,9 +338,8 @@ public function throwIfStatus($statusCode)
      */
     public function throwUnlessStatus($statusCode)
     {
-        if (is_callable($statusCode) &&
-            ! $statusCode($this->status(), $this)) {
-            return $this->throw();
+        if (is_callable($statusCode)) {
+            return $statusCode($this->status(), $this) ? $this : $this->throw();
         }
 
         return $this->status() === $statusCode ? $this : $this->throw();

diff --git a/tests/Http/HttpClientTest.php b/tests/Http/HttpClientTest.php
@@ -2194,6 +2194,16 @@ public function testRequestExceptionIsThrownUnlessStatusCodeIsSatisfied()
         }
 
         $this->assertNull($exception);
+
+        $exception = null;
+
+        try {
+            $this->factory->get('http://foo.com/api/500')->throwUnlessStatus(fn ($status) => $status === 500);
+        } catch (RequestException $e) {
+            $exception = $e;
+        }
+
+        $this->assertNull($exception);
     }
 
     public function testRequestExceptionIsThrownIfIsClientError()