Add type hinting for lateral join methods

laravel · Feb 16, 2024 · b31ddd1 · b31ddd1
1 parent 021acc9
commit b31ddd1
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 6 deletions.
diff --git a/src/Illuminate/Database/Query/Builder.php b/src/Illuminate/Database/Query/Builder.php
@@ -594,7 +594,7 @@ public function joinSub($query, $as, $first, $operator = null, $second = null, $
      * @param  string  $type
      * @return $this
      */
-    public function joinLateral($query, $as, $type = 'inner')
+    public function joinLateral($query, string $as, string $type = 'inner'): static
     {
         [$query, $bindings] = $this->createSub($query);
 
@@ -614,7 +614,7 @@ public function joinLateral($query, $as, $type = 'inner')
      * @param  string  $as
      * @return $this
      */
-    public function leftJoinLateral($query, $as)
+    public function leftJoinLateral($query, string $as): static
     {
         return $this->joinLateral($query, $as, 'left');
     }

diff --git a/src/Illuminate/Database/Query/Grammars/Grammar.php b/src/Illuminate/Database/Query/Grammars/Grammar.php
@@ -199,7 +199,7 @@ protected function compileJoins(Builder $query, $joins)
      *
      * @throws \RuntimeException
      */
-    public function joinLateral(JoinClause $join, string $expression)
+    public function joinLateral(JoinClause $join, string $expression): string
     {
         throw new RuntimeException('This database engine does not support lateral joins.');
     }

diff --git a/src/Illuminate/Database/Query/Grammars/MySqlGrammar.php b/src/Illuminate/Database/Query/Grammars/MySqlGrammar.php
@@ -241,7 +241,7 @@ protected function compileUpdateColumns(Builder $query, array $values)
      * @param  string  $expression
      * @return string
      */
-    public function joinLateral(JoinClause $join, string $expression)
+    public function joinLateral(JoinClause $join, string $expression): string
     {
         return trim("{$join->type} join lateral {$expression} on true");
     }

diff --git a/src/Illuminate/Database/Query/Grammars/PostgresGrammar.php b/src/Illuminate/Database/Query/Grammars/PostgresGrammar.php
@@ -393,7 +393,7 @@ protected function compileUpdateColumns(Builder $query, array $values)
      * @param  string  $expression
      * @return string
      */
-    public function joinLateral(JoinClause $join, string $expression)
+    public function joinLateral(JoinClause $join, string $expression): string
     {
         return trim("{$join->type} join lateral {$expression} on true");
     }

diff --git a/src/Illuminate/Database/Query/Grammars/SqlServerGrammar.php b/src/Illuminate/Database/Query/Grammars/SqlServerGrammar.php
@@ -394,7 +394,7 @@ protected function compileUpdateWithJoins(Builder $query, $table, $columns, $whe
      * @param  string  $expression
      * @return string
      */
-    public function joinLateral(JoinClause $join, string $expression)
+    public function joinLateral(JoinClause $join, string $expression): string
     {
         $type = $join->type == 'left' ? 'outer' : 'cross';