fix: primitive variadic class make (#43985)

laravel · Sep 5, 2022 · 150bd1b · 150bd1b
1 parent 0c18029
commit 150bd1b
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 0 deletions.
diff --git a/src/Illuminate/Container/Container.php b/src/Illuminate/Container/Container.php
@@ -1006,6 +1006,10 @@ protected function resolvePrimitive(ReflectionParameter $parameter)
             return $parameter->getDefaultValue();
         }
 
+        if ($parameter->isVariadic()) {
+            return [];
+        }
+
         $this->unresolvablePrimitive($parameter);
     }
 

diff --git a/tests/Container/ContainerResolveNonInstantiableTest.php b/tests/Container/ContainerResolveNonInstantiableTest.php
@@ -23,6 +23,14 @@ public function testResolvingNonInstantiableWithVariadicRemovesWiths()
         $this->assertCount(0, $parent->child->objects);
         $this->assertSame(42, $parent->i);
     }
+
+    public function testResolveVariadicPrimitive()
+    {
+        $container = new Container;
+        $parent = $container->make(VariadicPrimitive::class);
+
+        $this->assertSame($parent->params, []);
+    }
 }
 
 interface TestInterface
@@ -73,3 +81,16 @@ public function __construct(TestInterface ...$objects)
         $this->objects = $objects;
     }
 }
+
+class VariadicPrimitive
+{
+    /**
+     * @var array
+     */
+    public $params;
+
+    public function __construct(...$params)
+    {
+        $this->params = $params;
+    }
+}