-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.x] Add option to force the password to have a special character. #65
[1.x] Add option to force the password to have a special character. #65
Conversation
Looks good to me. |
src/Rules/Password.php
Outdated
case $this->requireUppercase | ||
&& ! $this->requireNumeric | ||
&& ! $this->requireSpecialCharacter: | ||
return __('The :attribute must be at least '.$this->length.' characters and contain at least one uppercase character.'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should probably changed to something like: return __('The :attribute must be at least :length characters and contain at least one uppercase character.', ['length' => $this->length]);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@buismaarten Please check it now. Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@leo95batista looks better!
This PR has merge conflicts. Also why |
Hello, good morning everyone! , @taylorotwell I am reviewing, and I see that the PR #70 was approved first before this PR #65. For that reason the conflict. In PR #70, they changed the style in which the Before
Now
I think |
@taylorotwell , do you think anything else needs to be changed before doing the merge? |
Hi! I have created this PR with the intention of adding in the password validation rules the option to require that the password contain or not special characters.
Regards.