Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.x] Add TwoFactorAuthenticationFailed event #558

Merged
merged 5 commits into from
Jul 22, 2024

Conversation

antergos98
Copy link
Contributor

Hi Taylor,

Thank you for Fortify. It's our first time using it heavily, and we really enjoy the package so far.

In our project, we need to log 2FA events in a database table. Although Fortify already dispatches some events, we require one that is currently missing. This PR adds that event. I believe this is a low-risk change, and I'm happy to move the event call elsewhere if you prefer.

@taylorotwell
Copy link
Member

Any reason not to use the abstract TwoFactorAuthenticationEvent class as the base class?

@taylorotwell taylorotwell marked this pull request as draft July 19, 2024 16:15
@antergos98
Copy link
Contributor Author

@taylorotwell Fixed

@antergos98 antergos98 marked this pull request as ready for review July 19, 2024 16:21
@taylorotwell taylorotwell merged commit 33f8af0 into laravel:1.x Jul 22, 2024
7 checks passed
@antergos98 antergos98 deleted the 1.x-two-factor-failed-event branch July 22, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants