[1.x] Naming 2FA routes for consistency #269
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After I included Fortify in an old Laravel project (with laravel ui), I was forced myself to use the url() helper instead the route() helper because some routes had no names on it. I added names to the following routes:
/user/two-factor-authentication => two-factor.toggle
/user/two-factor-qr-code => two-factor.qr-code
/user/two-factor-recovery-codes => two-factor.recovery-codes
Now I can use:
instead
like other routes of Fortify. I used toggle because it enables and disables the 2FA for the user. Maybe a better name is found for that.
The tests can be modified to use route() helper but I don't know if that is really necessary.