[6.x] add Chrome driver auto detection #816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What does this do exactly? What do you mean by "determine the install driver version"? |
|
sorry, should have said "the installed chromium version". this checks the currently installed version of Chromium, and uses that to install the appropriate Driver version. for example, on linux, it would run So let's say the installed version is 84.0.123.45. |
|
@browner12 can you maybe also send in a PR to the docs for this? |
|
sure thing |
browner12
added a commit
to browner12/docs
that referenced
this pull request
Sep 29, 2020
browner12
added a commit
to browner12/docs
that referenced
this pull request
Sep 29, 2022
the `--detect` flag was added to Dusk in laravel/dusk#816 which automatically downloads the correct driver based on the version of Chrome currently installed on the system.
taylorotwell
pushed a commit
to laravel/docs
that referenced
this pull request
Sep 29, 2022
the `--detect` flag was added to Dusk in laravel/dusk#816 which automatically downloads the correct driver based on the version of Chrome currently installed on the system.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the
--detectflag, the command will see if it can determine the install driver version, and then install the latest of that major version.All credit goes to @staudenmeir. This code was taken from https://github.com/staudenmeir/dusk-updater.
In our next major release, I feel like this should be the default option, and we should add a
--latestflag to get back to the current default behavior.