[6.x] Pass ssl-no-verify option into latestVersion of ChromeDriver install #794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driesvints
approved these changes
Jul 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses #793 . The --ssl-no-verify option currently doesn't apply to the "latestVersion" call when installing the chrome driver. This causes a failure with ssl proxies which cause ssl verification issues.
The fix:
Build an ssl verification option and pass it into the file_get_contents call for latest version. Note: This has been tested on my local (with SSL verification on and off) and appears to work.
Tests:
I do not see any tests for this file in the repo. I can add tests, but I want to make sure it is necessary first. Please let me know if tests are needed for this issue.
Thank you,
Matt