[5.x] Add graceful handler for SIGINT for .env restoration #682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driesvints
previously requested changes
Oct 14, 2019
|
Don't use declare(ticks=1)... use asnyc signals which are available on all versions of PHP that Dusk requires. |
|
Agreed; change is made with 874df3f. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that if the
php artisan duskcommand is cancelled by a CTRL+C (command cancel, i.e. SIGINT), the original .env is restored correctly.We often run a dusk test, and cancel within the test suite if an issue comes up. In that case, the
.env.backupisn't restored, and requires it to be restored manually.Also adds a
try {} finally {}clause if the Dusk commands fails themself the environment is still restored.