Adds back PHP_BINARY to phpunit process

[jhoff]

Disclaimer: Not sure of the implications of this on windows, as I can't test it...

A while back a pull request was accepted that ensured PHP_BINARY was used for phpunit. Almost immediately after, that change was reverted in a refactor. This brings that fix back.

[taylorotwell]

So why are we adding it back?

[jhoff]

This change simply makes sure that phpunit is run with the same version of php that you executed artisan with. Without it, phpunit will try and resolve php from the current environments $PATH, but symfony's process executes the command in a fresh environment that doesn't inherit $PATH from the executed environment.

In our case, we are running tests with different versions of php depending on the project we're currently working with so we can't rely on $PATH to resolve the correct version for us.

[taylorotwell]

So why was it reverted?

[jhoff]

As far as I can tell, the original fix was accepted and then in the very next merge commit it was gone completely:

db89a68
da7508e ( specifically here:

dusk/src/Console/DuskCommand.php

Line 43 in da7508e

public function handle()

)

If you trace back the commit parents on that second merge commit, it looks like the refactor was here:

00338d5#diff-9b77ed94c2c2c5083de8ec6cc456096eR49

I don't think it was intentionally reverted, just overlapping merge requests with outdated base commits.