[1.0.13] Supress Symphony exception when TTY is not available #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mamor
added a commit
to mamor/dusk-on-wercker-example
that referenced
this pull request
Apr 18, 2017
|
Tag, tag, tag, tag 🥇 |
|
This would be great! |
|
@martijnimhoff Think it's been tagged now. |
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of trying to figure out whether TTY is available or not, let Symphony come up with the answer for this (no need to reinvent the wheel). If they tell us it's not available (by throwing an exception), simply ignore it. The side effect is basically no colors on your tests, which people running on CI might not care and/or the CI itself might implement colors themselves.
Without TTY:
With TTY:
Should be enough to close #202 and provide liable solution for people supporting #136