[7.x] Keyboard Support Improvements

[crynobone]

Before

$key = PHP_OS_FAMILY === 'Darwin' ? \Facebook\WebDriver\WebDriverKeys::COMMAND : \Facebook\WebDriver\WebDriverKeys::CONTROL;

$this->browse(function (Browser $browser) use ($key) {
    $browser
        ->visit('/first')
        // ...
        ->tap(function (Browser $browser) use ($key) {
            $browser->driver->getKeyboard()->pressKey($key);
        })
        ->click('@link.to.second')
        ->tap(function (Browser $browser) use ($key) {
            $browser->driver->getKeyboard()->releaseKey($key);
        })
        // ...
    ;
});

After

$key = PHP_OS_FAMILY === 'Darwin' ? \Facebook\WebDriver\WebDriverKeys::COMMAND : \Facebook\WebDriver\WebDriverKeys::CONTROL;

$this->browse(function (Browser $browser) use ($key) {
    $browser
        ->visit('/first')
        // ...
        ->usesKeyboard(function (Keyboard $keyboard) use ($key) {
            $keyboard->press($key);
            $keyboard->browser->click('@link.to.second');
            $keyboard->release($key);
        }) 
        // or alternatively
        ->controlClick('@link.to.second')
        // ...
    ;
});

[taylorotwell]

I don't quite follow this part. On my macOS keyboard I have a control key and a "meta" / command key. Why do we use the meta key for Mac here if some Mac keyboards have an actual control key?

[crynobone]

COMMAND and META represent the same keystroke in Mac : https://github.com/php-webdriver/php-webdriver/blob/a1578689290055586f1ee51eaf0ec9d52895bb6d/lib/WebDriverKeys.php#L90

The primary issue here is that Windows uses Control+click while Mac uses Command+click to trigger open in new tab. Similar issue can occur for action combo such as copy text etc.