-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add alternative tag for element selection #1012
feat: add alternative tag for element selection #1012
Conversation
hooray! |
This reverts commit eedf08c.
We just reverted this because it was breaking Nova's test suite. |
Hi, I do believe this is a great addition to Dusk and Nova should use This PR should work great in some scenario however any interaction with elements where we need to use |
@driesvints @crynobone Any chance in bringing this back in the future? |
@pataar mior answered this above your reply. |
@driesvints Alright, thanks! |
This is now added by Taylor: cf04717 |
This adds the alternative
data-dusk="tag"
attribute. As described in: https://developer.mozilla.org/en-US/docs/Learn/HTML/Howto/Use_data_attributes: attributes that are not part of the spec should be prefixed withdata-
.Currently TSX does not allow any attributes that aren't defined in the spec, unless they have a data prefix. So without an alternative attribute to
dusk=
, TSX users won't be able to use Dusk as documented.