Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.x] Update Horizon Documentation to reflect the allowed waits config values #9111

Merged
merged 3 commits into from
Nov 1, 2023
Merged

Conversation

robinnydahl
Copy link
Contributor

After investigation into why our Horizon installs are still reporting long waits after 60 seconds when it's explicitly stated otherwise in the config, we did some further research.

We have seen that the waits array in the Horizon config does not accept multiple queues passed with commas, as seen in the code itself (see link below).

https://github.com/laravel/horizon/blob/fd5c8957e08419455cce6efdfc8f2c38a812debd/src/Listeners/MonitorWaitTimes.php#L56

Due to this, the documentation seem to be outdated/incorrect and has been updated to reflect both the default wait, which is 60 seconds, and how it would look if you have multiple queues with different wait times to report on.

@robinnydahl robinnydahl changed the title Update Horizon Documentation to reflect the allowed waits config values [10.x] Update Horizon Documentation to reflect the allowed waits config values Nov 1, 2023
@taylorotwell taylorotwell merged commit aaa7ed8 into laravel:10.x Nov 1, 2023
@robinnydahl robinnydahl deleted the patch-1 branch November 6, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants