Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Undocumented WaitsForElements Methods #3409

Merged
merged 2 commits into from
Jun 30, 2017
Merged

Add Undocumented WaitsForElements Methods #3409

merged 2 commits into from
Jun 30, 2017

Conversation

paulredmond
Copy link
Contributor

@paulredmond
Add Undocumented Methods for the WaitsForElements Concern
16f962e 
Updates a few undocumented features for waiting on things.
@paulredmond
Copy link
Contributor Author

paulredmond commented Jun 29, 2017 •
edited
Loading

I did actually have a question about the feature from laravel/dusk#176:

I could be missing something.

When using $browser->waitForLocation('/secret'); it seems like a $browser->assertLocation('/secret') would become redundant since the waitForLocation is actually going to fail unless it gets to the asserted location. Any thoughts on this?

@paulredmond paulredmond changed the title Add Undocumented Methods for the WaitsForElements Concern Add Undocumented WaitsForElements Methods Jun 29, 2017
@taylorotwell taylorotwell merged commit 5862277 into laravel:5.4 Jun 30, 2017
@paulredmond paulredmond deleted the feature/more-waiting-docs branch October 24, 2018 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulredmond @taylorotwell