Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[9.0] Add support for options on subscription swap #618

Closed
wants to merge 3 commits into from
Closed

[9.0] Add support for options on subscription swap #618

wants to merge 3 commits into from

Conversation

keithbrink
Copy link
Contributor

This resolves #580 - you can now pass in parameters when swapping a subscription, such as a coupon.

I believe this would also resolve #550, but I haven't tested it.

@taylorotwell
Copy link
Member

Please remove your comment.

@keithbrink
Copy link
Contributor Author

Done.

@driesvints driesvints changed the title Add support for options on subscription swap [9.0] Add support for options on subscription swap Mar 18, 2019
@driesvints
Copy link
Member

driesvints commented Mar 18, 2019 •
edited
Loading

This is a breaking change on the swap method signature for people who are overriding this and is best to be sent to the master branch.

@driesvints driesvints closed this Mar 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ability to add coupon in swap How can I add trial days to an existing subscription?
3 participants
@keithbrink @taylorotwell @driesvints