Automatically boot Cashier from config files #531
Labels
Milestone
Comments
|
Yeah I can see how a config file might be of use. I'll mark this as a feature request. Feel free to send in a PR to the master branch. |
driesvints
added a commit
that referenced
this issue
Apr 15, 2019
This commit sets a fixed Stripe API version for all Stripe API calls made from Cashier. It's being passed as an option to all calls together with the api key. The way options are handled has also been refactored so this is now entirely done on the Cashier class while keeping the Billable entity free from any configuration related options. This may later still be changed when a config file for Cashier is introduced: #531 Closes #621 and #642
driesvints
added a commit
that referenced
this issue
Apr 16, 2019
This commit sets a fixed Stripe API version for all Stripe API calls made from Cashier. It's being passed as an option to all calls together with the api key. The way options are handled has also been refactored so this is now entirely done on the Cashier class while keeping the Billable entity free from any configuration related options. This may later still be changed when a config file for Cashier is introduced: #531 Closes #621 and #642
driesvints
added a commit
that referenced
this issue
Jun 27, 2019
Cashier is at the moment one of the only Laravel packages which doesn't uses a config file. I think it would be better if it was more in line of the other packages by making use of one. This is what people are used to as well. These changes add a config file and cleans up the way configuration is handled within cashier. Another small change is the rename of STRIPE_MODEL to CASHIER_MODEL since that env variable is Cashier specfic and not Stripe specific. This also allows us to easily add new config options in later pull requests (like the email reminder option in the payment intents PR). Closes #531
|
This was merged and will be included in the next release. |
gler1016
added a commit
to gler1016/laravel-stripe-cashier
that referenced
this issue
Jan 3, 2025
This commit sets a fixed Stripe API version for all Stripe API calls made from Cashier. It's being passed as an option to all calls together with the api key. The way options are handled has also been refactored so this is now entirely done on the Cashier class while keeping the Billable entity free from any configuration related options. This may later still be changed when a config file for Cashier is introduced: laravel/cashier-stripe#531 Closes laravel/cashier-stripe#621 and laravel/cashier-stripe#642
gler1016
added a commit
to gler1016/laravel-stripe-cashier
that referenced
this issue
Jan 3, 2025
Cashier is at the moment one of the only Laravel packages which doesn't uses a config file. I think it would be better if it was more in line of the other packages by making use of one. This is what people are used to as well. These changes add a config file and cleans up the way configuration is handled within cashier. Another small change is the rename of STRIPE_MODEL to CASHIER_MODEL since that env variable is Cashier specfic and not Stripe specific. This also allows us to easily add new config options in later pull requests (like the email reminder option in the payment intents PR). Closes laravel/cashier-stripe#531
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This proposal depends on laravel/laravel#4675.
The idea is to automatically boot Cashier with values from a config file. This way, a user will unlikely have to call
Cashier::useCurrency()anymore.Here is my suggestion: a1a5921
PS: Also depends on #530
The text was updated successfully, but these errors were encountered: