[6.x] Utilise illuminate/testing based on #122 #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
c1fbeeb to
c3ab74a
Compare
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
1. I cannot find anything related to the original `PHPUnit\Framework\Assert::assertJson()` 2. This mainly aim to check if response is actually JSON. Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog note
All HTTP tests will now return an instance of
Laravel\BrowserKitTesting\TestResponseinstead ofIlluminate\Http\Response. The advantage of having TestResponse is that you have access to every assertion available in Laravel HTTP Tests > Response Assertions.This PR no longer add any breaking change. Old and new methods can be used.
Signed-off-by: Mior Muhammad Zaki crynobone@gmail.com