Skip to content

Commit

Permalink
Update minimum Laravel version
Browse files Browse the repository at this point in the history
  • Loading branch information
@driesvints
driesvints committed Feb 5, 2019
1 parent d4f4894 commit 1185004
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions composer.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@
"php": ">=7.1.3",
"ext-dom": "*",
"ext-json": "*",
"illuminate/database": "^5.7",
"illuminate/http": "^5.7",
"illuminate/support": "^5.6",
"illuminate/database": "~5.7.0",
"illuminate/http": "~5.7.0",
"illuminate/support": "~5.7.0",

This comment has been minimized.

Sign in to view

Copy link
@crynobone

crynobone Feb 9, 2019

Member

This will prevent installation to 5.8 or above.

@driesvints @taylorotwell @GrahamCampbell

This comment has been minimized.

Sign in to view

Copy link
@driesvints

driesvints Feb 9, 2019

Author Member

@crynobone yes, next week I'm going to add 5.8 support to all libraries.

This comment has been minimized.

Sign in to view

Copy link
@crynobone

crynobone Feb 9, 2019

Member

What's odd is previously you can install 5.8 because of the ^5.6 constraint.

This comment has been minimized.

Sign in to view

Copy link
@driesvints

driesvints Feb 9, 2019

Author Member

We've decided to change this to prevent people from installing versions which aren't tested yet.

This comment has been minimized.

Sign in to view

Copy link
@GrahamCampbell

GrahamCampbell Feb 9, 2019

Member

We've decided to change this to prevent people from installing versions which aren't tested yet.

This doesn't prevent that though, because compose can just resolve the version just before you made this change?

This comment has been minimized.

Sign in to view

Copy link
@driesvints

driesvints Feb 9, 2019

Author Member

@GrahamCampbell it should prevent it afaik?

This comment has been minimized.

Sign in to view

Copy link
@GrahamCampbell

GrahamCampbell Feb 9, 2019

Member

No, 4.x can still be installed on Laravel 5.8.

This comment has been minimized.

Sign in to view

Copy link
@GrahamCampbell

GrahamCampbell Feb 9, 2019

Member

In particular, 4.2.0 will be installed on laravel 5.8 along side phpunit 8.x, because composer won't be able to resolve 4.2.1 or 5.0.0.

This comment has been minimized.

Sign in to view

Copy link
@driesvints

driesvints Feb 10, 2019

Author Member

@GrahamCampbell can you ping me on discord or larachat next week to talk this over? Because I can't follow 😅

This comment has been minimized.

Sign in to view

Copy link
@driesvints

driesvints Feb 11, 2019

Author Member

@GrahamCampbell ah I see what you mean. We indeed didn't update the version constraint for 4.x because we're only adopting the new notation since this new major version. But I'm going to add the 5.8 constraints this week.

This comment has been minimized.

Sign in to view

Copy link
@driesvints

driesvints Feb 12, 2019

Author Member

v5.1.0 was released now with 5.8 support: d1be15a
"mockery/mockery": "^1.0",
"phpunit/phpunit": "^7.0|^8.0",
"symfony/console": "^4.2",
Expand Down

0 comments on commit 1185004

Please sign in to comment.