[Inertia] Update <Link> tags & implement <Head> management (title tag) #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
claudiodekker
commented
Jul 20, 2021
- Adjust changes as done in [Inertia] Update <Link> tags & implement <Head> management (title tag) jetstream#832
- Implements -management support as to allow for per-page title tags.
- Moves forms etc. to a 'Partials' subfolder, as to more clearly indicate which files are "Pages" and which aren't.
joshuapack
reviewed
Jul 23, 2021
| @@ -1,5 +1,15 @@ | |||
| <template> | |||
| <inertia-link class="block w-full px-4 py-2 text-left text-sm leading-5 text-gray-700 hover:bg-gray-100 focus:outline-none focus:bg-gray-100 transition duration-150 ease-in-out"> | |||
| <Link class="block w-full px-4 py-2 text-left text-sm leading-5 text-gray-700 hover:bg-gray-100 focus:outline-none focus:bg-gray-100 transition duration-150 ease-in-out"> | |||
There was a problem hiding this comment.
This is missing a href attribute. We will get an error like this inertiajs/inertia#744 if no href attribute on a Link.
pro-kurt
reviewed
Jul 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.