Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EmailVerificationTest to pass using Uuids #85

Merged
merged 1 commit into from
Jun 21, 2021
Merged

Fix EmailVerificationTest to pass using Uuids #85

merged 1 commit into from
Jun 21, 2021

Conversation

salvobee
Copy link
Contributor

Most of the solutions to use UUIDs as primary key for models relies on Eloquent events.
The Breeze email verification's test fakes the Event bus before a fake user is created, so if you're going to use an event based solution for generating uuid it will fail while trying to create the user (integrity constraint on SQL).
The solution should be quite easy: creating the user before start faking the event bus.

Sorry if I've missed something, this is my very first PR! 😊

Most of the solutions to use UUIDs as primary key for models relies on Eloquent events.
The Breeze email verification's test fakes the Event bus before a fake user is created, so if you're going to use an event based solution for generating uuid it will fail while trying to create the user (integrity constraint on SQL).
The solution should be quite easy: creating the user before start faking the event bus.
@taylorotwell taylorotwell merged commit bd13b66 into laravel:1.x Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants