[1.x] Reduce verbosity by introducing a 'Guest' layout #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses Inertia's persistent layouts feature to reduce verbosity in all 'guest' (auth) views. This makes the
AuthenticationCard.vuecomponent entirely redundant, while also making it easier for the developer to customize their fresh Breeze install.Furthermore, as a side-effect of this change, it also fixes a bug where the application logo was being rendered but was invisible on the
Auth/VerifyEmailpage (due to missing the classes that were being assigned in all other views).Next, because of this new
Guestlayout, I've also renamed theAppLayouttoAuthenticated, as both the guest-side of the application as well as the authenticated-side of the application are part of the 'app'.Finally, I've aligned all usages of
<slot></slot>to use<slot />as was already the case in some views. This doesn't change the way anything works at all and is purely syntaxial.