Use appName directly from .env in <title> #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domnantas
commented
Jun 19, 2023
| @@ -4,7 +4,7 @@ import createServer from '@inertiajs/react/server'; | |||
| import { resolvePageComponent } from 'laravel-vite-plugin/inertia-helpers'; | |||
| import route from '../../vendor/tightenco/ziggy/dist/index.m'; | |||
|
|
|||
| const appName = 'Laravel'; | |||
| const appName = import.meta.env.VITE_APP_NAME || 'Laravel'; | |||
There was a problem hiding this comment.
ssr can also use process.env to access envs (even without the VITE_ prefix)
There was a problem hiding this comment.
I like that it is consistent and uses VITE_APP_NAME, otherwise if you remove that ENV it could work in SSR and not a normal build.
There was a problem hiding this comment.
I agree. Using process.env would be a good example of accessing secrets/api keys and not exposing them to the frontend, but using it here would be a little misleading
|
Tests fail here. |
timacdonald
approved these changes
Jun 20, 2023
|
I've created a fix for the TS failure here: #293 It is unrelated to this PR. |
jessarcher
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
appNamein app.tsx is pulled via DOM from app.blade.php <title> tag. It works, but using it from .env seems like a better approach. Additionally, it serves as an example of how .env variables should be accessed in React/Vue.The
ssrtemplates had'Laravel'hardcoded as the app name, which is not great for SEO. Replaced those parts withimport.meta.env.VITE_APP_NAMEas well.This depends on laravel/laravel#6204 where I added
VITE_APP_NAMEas an alias toAPP_NAMEI don't think any changes in this PR could be considered breaking.
Similar issue fixed in Jetstream: laravel/jetstream#1329