Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just some very minor changes to make the package more SPA compatible out the box:
RequestGuard
and fail.ValidationException
if the confirmed password is invalid.There's of course many ways to implement both points, I've gone with the least amount of change, however:
StatefulGuard
in the constructor like Fortify's AuthenticatedSessionController and ConfirmablePasswordController.if ($request->wantsJson()) {
conditional and keep theback()
redirect for server rendered apps, again like Fortify's FailedPasswordConfirmationResponse.Happy to change this request to your preferred implementation if acceptable.
Thanks for your time,
Sam