Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.x] Vite 3 support #171

Merged
merged 4 commits into from
Jul 19, 2022
Merged

[1.x] Vite 3 support #171

merged 4 commits into from
Jul 19, 2022

Conversation

timacdonald
Copy link
Member

@timacdonald timacdonald commented Jul 14, 2022

Dependent PRs

Although it may be possible to allow '@inertiajs/server' to be externalised, to get this across the line now I think we just move forward and can iterate if we can solve it upstream with Inertia.

@timacdonald timacdonald requested a review from jessarcher July 17, 2022 05:53
@jessarcher
Copy link
Member

@timacdonald As with Jetstream, I've created a branch that keeps a single config file: https://github.com/laravel/breeze/compare/vite-3-single-config

Keen to hear your thoughts!

@jessarcher jessarcher marked this pull request as ready for review July 19, 2022 04:06
@taylorotwell taylorotwell merged commit 416c092 into 1.x Jul 19, 2022
@taylorotwell taylorotwell deleted the vite-3 branch July 19, 2022 14:03
slimani-dev pushed a commit to slimani-dev/breeze that referenced this pull request Jan 21, 2023
* vite 3 support

* don't externalise inertia server

* CS

* Use a single Vite config file

Co-authored-by: Jess Archer <jess@jessarcher.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants