[1.x] Improve Vite compatibility #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This improves the transition for Vite users.
d664676 to
f0733c0
Compare
drewmw5
pushed a commit
to drewmw5/breeze
that referenced
this pull request
Nov 11, 2022
* Use jsx extension for files containing JSX * Switch to ESM imports This improves the transition for Vite users.
slimani-dev
pushed a commit
to slimani-dev/breeze
that referenced
this pull request
Jan 21, 2023
* Use jsx extension for files containing JSX * Switch to ESM imports This improves the transition for Vite users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the following changes in order to make the transition to Vite easier, without breaking the current webpack/Mix setup:
.jsxextension (see Evan You's tweet for reasoning)requirestatements to use ESMimportstatements (see [9.x] Switch to ESM imports laravel#5895 and [2.x] Switch to ESM imports jetstream#1059)