update cors.php #144
Merged
update cors.php #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slimani-dev
pushed a commit
to slimani-dev/breeze
that referenced
this pull request
Jan 21, 2023
Co-authored-by: trungpv <trungpv@trungpvs-MacBook-Pro-2.local>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This is the first time I make a pull request. Please let me know If I miss something. Thanks
About the issue
I deploy the app (Octane) with the api option to the forge. Somehow the env is not add the FRONTEND_URL in to the
.envfile by default. The 500 happen. After I check I realize I missing the FRONTEND_URL in the.envfile.Double check the source code and I saw the
cors.phpconfig file missing the default value.So, I make a patch. Please help me review. Thanks again 😇
Have a nice day. 🥳