Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove DBAL for Laravel 11 #668

Merged
merged 13 commits into from
Feb 17, 2024
Merged

Remove DBAL for Laravel 11 #668

merged 13 commits into from
Feb 17, 2024

Conversation

jasonmccreary
Copy link
Collaborator

No description provided.

@jasonmccreary
Copy link
Collaborator Author

While the tests are passing it seems some of the column attributes don't match up when testing the README example. I'm not sure if this is due to Laravel 10 versus Laravel 11, SQLite versus MySQL, or DBAL versus Laravel.

@hafezdivandari
Copy link

hafezdivandari commented Feb 16, 2024 •
edited
Loading

@jasonmccreary it's pretty good, let me send a PR based on your branch, then you can see if it helps.

(ref: laravel/framework#48864)

@hafezdivandari hafezdivandari mentioned this pull request Feb 16, 2024
Merged
@hafezdivandari
Copy link

@jasonmccreary you may check this #669

@jasonmccreary jasonmccreary merged commit 51effbf into master Feb 17, 2024
27 checks passed
@jasonmccreary jasonmccreary deleted the remove-dbal branch February 17, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jasonmccreary @hafezdivandari