With hypre #751
Closed
With hypre #751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ers and openMP offload
…ers and openMP offload
…ers and openMP offload
NOTE: Code currently supports only one precision build of hypre, so the integration is compatible with hypre built in single or double precision only.
This effort enables use of hypre for matrix multiplication and addition on GPUs. It relies on openMP offload to transfer BML data to hypre. NOTE: Current implementation supports NVIDIA GPUs.
jeanlucf22
requested changes
Mar 20, 2024
| // Done with matrix multiplication. | ||
| // Update ellpack C matrix (on device): copy from csr to ellpack format | ||
| /* | ||
| #pragma omp target data use_device_ptr(csrRowPtrC,csrColIndC,csrValC) |
There was a problem hiding this comment.
This commented section is actually what is needed for AMD. I left that in there as a place holder for now. I have updated the comments to reflect this.
…tion in hypre. * This effort enables use of hypre for matrix multiplication and addition on GPUs. * It relies on openMP offload to transfer BML data to hypre. * NOTE: Current implementation supports NVIDIA GPUs. * NOTE: Code currently supports only one precision build of hypre, so the integration is compatible with hypre built in single or double precision only. parent fa390fd author Daniel Osei-Kuffuor <oseikuffuor1@llnl.gov> 1697604624 -0700 committer Daniel Osei-Kuffuor <oseikuffuor1@llnl.gov> 1710920233 -0700
|
@jeanlucf22 commits have been squashed in commit 4a3445d Thanks. |
|
Please squash our commits @oseikuffuor1 . |
Still appears like multiple commits in PR |
|
@jeanlucf22 @nicolasbock the commits are a bit messy now so I will delete this PR and create a new one. |
|
Closing this PR in favor of PR#752 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables integrating hypre into BML to allow BML to access hypre's GPU capable sparse linear algebra routines, particularly, matrix multiplication and matrix addition.