Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix progress rocsparse tests #723

Merged
merged 1 commit into from
Jul 4, 2023
Merged

Fix progress rocsparse tests #723

merged 1 commit into from
Jul 4, 2023

Conversation

mewall
Copy link
Collaborator

@mewall mewall commented Jul 3, 2023 

Fix rocSPARSE bug causing progress issues

Issues:

o Ellpack progress tests were failing for rocSPARSE build
o Progress benchmark was also failing for N>=6000

Fix:

o bml_sort_rocsparse_ellpack was obtaining nnz from host array
o changed this to obtain nnz from device array

@mewall mewall force-pushed the fix_progress_rocsparse_tests branch from 9629ffa to 209f34d Compare July 3, 2023 19:52
@mewall
Fix rocSPARSE bug causing progress issues
a688b4e 
Issues:

o Ellpack progress tests were failing for rocSPARSE build
o Progress benchmark was also failing for N>=6000

Fix:

o bml_sort_rocsparse_ellpack was obtaining nnz from host array
o changed this to obtain nnz from device array
@mewall mewall force-pushed the fix_progress_rocsparse_tests branch from 209f34d to a688b4e Compare July 3, 2023 19:55
@mewall mewall linked an issue Jul 3, 2023 that may be closed by this pull request
rocSPARSE memory error for large matrix sizes #719
Closed
@jeanlucf22 jeanlucf22 merged commit 10c4a47 into master Jul 4, 2023
@jeanlucf22 jeanlucf22 deleted the fix_progress_rocsparse_tests branch July 4, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeanlucf22 jeanlucf22 jeanlucf22 approved these changes

@nicolasbock nicolasbock nicolasbock approved these changes

@cnegre cnegre Awaiting requested review from cnegre cnegre is a code owner

@suemni suemni Awaiting requested review from suemni suemni is a code owner

@tokshgithub tokshgithub Awaiting requested review from tokshgithub tokshgithub is a code owner

@jmohdyusof jmohdyusof Awaiting requested review from jmohdyusof jmohdyusof is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rocSPARSE memory error for large matrix sizes
3 participants
@mewall @nicolasbock @jeanlucf22