Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade base image to Focal #688

Merged
merged 1 commit into from
Apr 11, 2023
Merged

Upgrade base image to Focal #688

merged 1 commit into from
Apr 11, 2023

Conversation

nicolasbock
Copy link
Collaborator

GitHub is sunsetting Bionic.

Signed-off-by: Nicolas Bock nicolasbock@gmail.com

@nicolasbock nicolasbock self-assigned this Feb 7, 2023
@nicolasbock nicolasbock force-pushed the image branch 2 times, most recently from ca0376d to e51deb8 Compare February 8, 2023 00:53
@nicolasbock
Copy link
Collaborator Author

gcc-4.8 is not readily available on Focal. I suggest we drop the tests using this compiler version.

@jeanlucf22
Copy link
Collaborator

gcc-4.8 is not readily available on Focal. I suggest we drop the tests using this compiler version.

I would be ok with that

@nicolasbock nicolasbock force-pushed the image branch 3 times, most recently from ee02465 to a2cf133 Compare February 8, 2023 21:02
@nicolasbock nicolasbock force-pushed the image branch 2 times, most recently from b8b1fca to 0cbd7f7 Compare March 6, 2023 21:07
@nicolasbock nicolasbock mentioned this pull request Apr 10, 2023
Merged
@nicolasbock
Copy link
Collaborator Author

I rebased this branch. There is still a linter issue I am investigating.

@nicolasbock
Copy link
Collaborator Author

We are running into a regression in the indent tool. I have reported this problem to upstream. I will remove the source files that break the indent tool from the indent script until there is a proper upstream fix.

@nicolasbock nicolasbock force-pushed the image branch 3 times, most recently from 8a36e05 to 337fb98 Compare April 11, 2023 03:08
@nicolasbock
Upgrade base image to Focal

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
6bb4e2d 
GitHub is sunsetting Bionic. This change uses gcc-10 for CI as gcc-11 is
not readily available on Focal.

Signed-off-by: Nicolas Bock <nicolasbock@gmail.com>
@nicolasbock nicolasbock merged commit e6f1880 into lanl:master Apr 11, 2023
@nicolasbock nicolasbock deleted the image branch April 11, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cnegre cnegre

@jeanlucf22 jeanlucf22

@suemni suemni

@tokshgithub tokshgithub

@jmohdyusof jmohdyusof

Assignees

@nicolasbock nicolasbock

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicolasbock @jeanlucf22 @cnegre