Offload mods for crusher development #633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeanlucf22
reviewed
Jun 23, 2022
suemni
approved these changes
Jun 23, 2022
dd9b44d to
7572bec
Compare
jeanlucf22
approved these changes
Jun 23, 2022
o Modified CMake scripts:
- Use BML_OMP_OFFLOAD for both NVIDIA and AMD,
needed due to commit #8a7df493
- Use FindCUDAToolkit module instead of depracated FindCUDA
- Update to CMake 3.17 version, to support FindCUDAToolkit
- Consolidated the logic for CUDA, HIP, and associated libraries
for various types of device builds under control of BML_USE_DEVICE
- Added BML_OFFLOAD_ARCH with options NVIDIA and AMD
o Change crusher and spock build scripts accordingly
o Modified offload regions to address bml_multiply_x2()
fortran test failure (hang)
- Move temporary working arrays all_ix, all_jx, and all_x from stack to heap
- This eliminated the hang, although it's not really clear why
- Similar changes made to other add, multiply offload regions
nicolasbock
requested changes
Jun 25, 2022
nicolasbock
approved these changes
Jun 28, 2022
|
Thanks @mewall ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
o Modified CMake scripts:
- Use BML_OMP_OFFLOAD for both NVIDIA and AMD,
needed due to commit #8a7df493
- Use FindCUDAToolkit module instead of depracated FindCUDA
- Update to CMake 3.17 version, to support FindCUDAToolkit
- Consolidated the logic for CUDA, HIP, and associated libraries
for various types of device builds under control of BML_USE_DEVICE
- Added BML_OFFLOAD_ARCH with options NVIDIA and AMD
o Change crusher build script to use new CMakeLists.txt and build.sh
o Modified offload regions to address bml_multiply_x2()
fortran test failure (hang)
- Move temporary working arrays all_ix, all_jx, and all_x from stack to heap
- This eliminated the hang, although it's not really clear why
- Similar changes made to other add, multiply offload regions